fix(checkbox): re-evaluate label visibility when label is updated#30980
Open
OS-jacobbell wants to merge 4 commits intomainfrom
Open
fix(checkbox): re-evaluate label visibility when label is updated#30980OS-jacobbell wants to merge 4 commits intomainfrom
OS-jacobbell wants to merge 4 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
bot
added
package: core
ShaneK
requested changes
Feb 27, 2026
Member
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
Looking good! Just a couple of change requests
packages/angular/test/base/src/app/standalone/value-accessors/checkbox/checkbox.component.ts
Outdated
Show resolved
Hide resolved
ShaneK
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Checkbox's render function applies the
label-text-wrapper-hiddencss class when there is no label text to prevent extra margin from being added. The render function is not re-evaluated if the label is updated. This causes a problem in Angular where dynamic variables get applied after the page is loaded, and a checkbox using a variable as a label gets stuck with its label hidden until something else triggers a re-render, e.g. ticking the box.What is the new behavior?
Does this introduce a breaking change?